This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author alexandre.vassalotti
Recipients alexandre.vassalotti, christian.heimes
Date 2007-10-09.03:28:26
SpamBayes Score 0.004846235
Marked as misclassified No
Message-id <1191900509.0.0.757119949429.issue1247@psf.upfronthosting.co.za>
In-reply-to
Content
I am not sure how the parser work, so I can't comment if your change to
it is correct. It would probably a better idea to keep it for later,
when the semantic differences between str8 and bytes objects will be
resolved.

I think changing b'' to buffer(b''), in the tests, is not a good idea.
These tests will need to be changed again when bytes() will be changed
to str8().

Your changes to PyString and PyBytes look good to me. As I said on the
mailing list, I think the for-loops in bytes_repr() should be changed to:

    while (*quote_prefix)
        *p++ = *quote_prefix++;

I attached updated patches with the above change. I also replaced
bytes() for buffer() in PyBytes's docstrings.
Files
File name Uploaded
change_bytes_repr_for_buffer.patch alexandre.vassalotti, 2007-10-09.03:28:27
History
Date User Action Args
2007-10-09 03:28:29alexandre.vassalottisetspambayes_score: 0.00484623 -> 0.004846235
recipients: + alexandre.vassalotti, christian.heimes
2007-10-09 03:28:29alexandre.vassalottisetspambayes_score: 0.00484623 -> 0.00484623
messageid: <1191900509.0.0.757119949429.issue1247@psf.upfronthosting.co.za>
2007-10-09 03:28:28alexandre.vassalottilinkissue1247 messages
2007-10-09 03:28:27alexandre.vassalotticreate