This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author collinwinter
Recipients
Date 2007-03-16.02:40:14
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Thanks for your patch!

Initial comments:

* test_pipes does not conform to PEP 8 (whitespace issues, line length, etc).
* SVN reports that test_pipes has inconsistent line endings.
* Calling os.path.exists() as a check before os.unlink() creates a race condition; just catch the exception.
* In the future, please include new files in the patch itself. "svn add" the file, then "svn diff" will include it when creating the diff.

Please address these issues.
History
Date User Action Args
2007-08-23 15:57:32adminlinkissue1680959 messages
2007-08-23 15:57:32admincreate