This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jimjjewett
Recipients
Date 2007-03-22.12:47:46
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Not sure if any of these are really problems, and it looks like Tony already looked them over before submitting, but still worth mentioning...

(1)  This does more than take out tuples, though the other changes do also look like things that ought to change for py3k.

(2)  I was amused by the name "stuff", but I couldn't think of a better name for that particular grouping.  (suffix, mode, type)

(3)  There are some signature changes, where the unpacking is now done by the caller, such as 

 class LeftShift(Node):
-    def __init__(self, (left, right), lineno=None):
+    def __init__(self, left, right, lineno=None):

(4)  The pdb change marks could be shortened a bit.  That shouldn't matter for patching, but I'll post it here since it helped me.

-    def user_exception(self, frame, (exc_type, exc_value, exc_traceback)):
+    def user_exception(self, frame, exc_info):
         """This function is called if an exception occurs,
         but only if we are to stop at or just below this level."""
+        (exc_type, exc_value, exc_traceback) = exc_info
         frame.f_locals['__exception__'] = exc_type, exc_value      
-        if type(exc_type) == type(''):
-            exc_type_name = exc_type
-        else: exc_type_name = exc_type.__name__
+        exc_type_name = exc_type.__name__
         print(exc_type_name + ':', _saferepr(exc_value), file=self.stdout)
         self.interaction(frame, exc_traceback)
History
Date User Action Args
2007-08-23 15:57:26adminlinkissue1678060 messages
2007-08-23 15:57:26admincreate