Author gvanrossum
Recipients
Date 2007-01-13.23:59:50
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Problems so far:

- Style: you set your tab stops to 4 spaces.  That is an absolute
no-no!  You can indent using 4 spaces, but you should NEVER assume
that a TAB character is anything except 8 spaces.

- Segfault in test_array. It seems that it's receiving a unicode slice
object and treating it like a "classic" unicode object.

- I got it to come to a grinding halt with the following worst-case scenario:

  a = []
  while True:
      x = u"x"*1000000
      x = x[30:60]  # Short slice of long string
      a.append(x)

If you can't do better than that, I'll have to reject it.

PS I used your combined patch, if it matters.
History
Date User Action Args
2007-08-23 15:56:04adminlinkissue1629305 messages
2007-08-23 15:56:04admincreate