Message51326
Logged In: YES
user_id=1038590
The retrieval of locals on a NULL argument and the sorting
step need to move back inside PyObject_Dir to avoid changing
the C API.
If the standard library's current C API tests didn't break
on this version of the patch, then the final version of the
patch should include enhanced tests for PyObject_Dir that
pass both before and after the patch is applied to PyObject_Dir.
Other than that, I didn't see any major problems on reading
the code (i.e. refcounts and error handling looked pretty
reasonable). I haven't actually run it though. |
|
Date |
User |
Action |
Args |
2007-08-23 15:55:15 | admin | link | issue1591665 messages |
2007-08-23 15:55:15 | admin | create | |
|