Message51322
I really like the idea of the lazy cats, and can believe that it's a really good optimisation, but before I review this code properly I'd like to see:
a. convincing that it doesn't break strict aliasing (a casual reading suggests it does)
b. lazy slices removed into their own patch (or just removed) - I don't want to recommend a patch containing them
c. adherence to coding standard
d. a little more explanation of how the cat objects work: it's important because they're a future minefield of bugs.
|
|
Date |
User |
Action |
Args |
2007-08-23 15:55:15 | admin | link | issue1590352 messages |
2007-08-23 15:55:15 | admin | create | |
|