Message51149
Logged In: YES
user_id=908
> * Needs documentation ...
True, I'll try to add more documentation...
> * I think we should be more paranoid about the range of
possible signals. NSIG does not appear to be defined by
SUSv2 (no clue about Posix). We should size the Handlers
array to UCHAR_MAX and set any signals outside the range of
0..UCHAR_MAX to either 0 (null signal) or UCHAR_MAX. I'm
not sure we should ever use NSIG.
I disagree. Creating an array of size UCHAR_MAX is just
wasting memory. If you check the original python code,
there's already fallback code to define NSIG if it's not
already defined (if not defined, it could end up being
defines as 64).
> * In signal_hander() sizeof(signum_c) is inherently 1. ;)
And? I occasionally hear horror stories of platforms where
sizeof(char) != 1, I'm not taking any chances :)
> * PyOS_InterruptOccurred() should probably still check
that it's called from the main thread.
check_signals already bails out if that is the case. But in
fact it bails out without setting the interrupt_occurred
output parameter, so I fixed that.
fcntl error checking... will work on it. |
|
Date |
User |
Action |
Args |
2007-08-23 15:54:43 | admin | link | issue1564547 messages |
2007-08-23 15:54:43 | admin | create | |
|