Author gvanrossum
Recipients
Date 2006-09-11.19:51:55
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Logged In: YES 
user_id=6380

General comment: I think you should update or add a comment
explaining the contents of the code object as it has changed
(unless that's all described in the PEP).

There are a number of places where the code is wider than 79
characters or where the indentatiln style seems to be off.
You may have to set your tabstops to 8 spaces to see these.

E.g.:

ceval.c:

- line 2624 should be indented with next line
- line 2680 is too long
- @@ -2694,13 +2715,35 @@ several lines too long
- line 3618 should be indented with the next line

ast.c: @@ -591,6 +591,63 @@ please follow the surrounding
4-space indents; don't use tabs here

marshal.c: line 871 too long

codeobject.c: several lines too long

funcobject.c: too long at "non-dict keyword only default args");

Lib/compiler/*.py: several lines too long

Lib/test/test_new.py

Modules/pyexpat.c: @@ -279,6 +279,7 @@ indentation error

Modules/parsermodule.c: several lines too long; the loop at
"while (res && i+1 < nch)" is indented one tabstop too many
(you seem to have edited this file with ts=4?)



History
Date User Action Args
2007-08-23 15:54:26adminlinkissue1549670 messages
2007-08-23 15:54:26admincreate