Message50712
Logged In: YES
user_id=21627
The patch looks wrong. Why are you deleting the _tkcommands
of the master widget if the variable is deleted? The master
could live much longer, and the commands might still be needed.
What is the purpose of the changes to trace_variable? You
are supposed to invoke trace_vdelete to release the callback.
Why are you catching TclError in so many cases? Under what
circumstances can you even get an error?
I think I would prefer if this patch was split into many
individual ones, each one fixing only a single bug (assuming
there are multiple bugs in Tkinter). |
|
Date |
User |
Action |
Args |
2007-08-23 15:53:36 | admin | link | issue1524639 messages |
2007-08-23 15:53:36 | admin | create | |
|