Message50657
Logged In: YES
user_id=12800
Thanks for the comments.
- I've changed it to GetSetDescriptorType
- 'data descriptor' is just what Python itself prints for
the type(getset_descriptor) so that's what I chose, but the
test should still be with isgetsetdescriptor(). Although
it's inconsistent with type(), I changed inspect.py's text
to read 'getset descriptor' since I think that's more accurate.
- I've changed false to \code{False} in the docs, but
libinspect.text uses "true" all over the place. I am not
changing that. :)
- updated the test and tried to make it pass in other
implementations.
Since no one else has really commented either for or
against, and the RM hasn't pronounced, I'm going to take
silence as approval and commit these changes later today. |
|
Date |
User |
Action |
Args |
2007-08-23 15:53:27 | admin | link | issue1520294 messages |
2007-08-23 15:53:27 | admin | create | |
|