Message50051
Logged In: YES
user_id=580910
Good points. I was clearing errors because it seemed better to ignore errors.
But you're right, if this does fail somethings is seriously wrong. I've replaced
error-checking by return statements (but have not replaced the patch).
The change to time is interesting, I added those changes because the binary
wouldn't run without the patch, without realizing that configure/timemodule
is picking up the wrong function for finding the current time. That seems to
be caused by a bug in the preprocessor code that selects the right section of
code. OSX 10.4 has both gettimeofday and ftime, and with the current set of
#if statements this means both the gettimeofday and ftime blocks get
compiled in. The ftime-bit is dead code, but present nonetheless.
I tried to rearange the #if-statements to make sure just one block gets
included, but then get compiler warnings because floattime checks for an
error-return of gettimeofday. IMHO the error-return check is rather lame,
the only reason this could fail is when the first argument of gettimeofday is
invalid (and SUS says this function will always return 0, although manpage on
darwin and linux claim otherwise), And time(2) can also return -1 to indicate
failure ;-)
If uploaded a new patch (version 2) that removes error clearing for the DelAttr
calls in posixmodule and chickens out on the ftime issue by #undef-ing
HAVE_FTIME for OSX systems that HAVE_GETTIMEOFDAY.
SUS: http://www.opengroup.org/onlinepubs/007908799/xsh/
gettimeofday.html |
|
Date |
User |
Action |
Args |
2007-08-23 15:48:21 | admin | link | issue1471925 messages |
2007-08-23 15:48:21 | admin | create | |
|