Message49668
Logged In: YES
user_id=33168
Object/object.c: You're right, my suggestion would leak v.
I originally was going to tell you to just call
PyErr_BadInternalCall(), but that is not what
PyObject_String() does. It's so messy to add a flag. :-( I
don't see any other way at the moment. Can you think of any
cleaner solution?
Objects/unicodeobject.c: yuck. I didn't notice the
shadowing. You're right the outer v does need a DECREF.
Please rename the inner v to avoid shadowing.
Objects/longobject.c: Oh, I see it now. I would prefer the
checks for a == NULL (and b == NULL) to be immediately after
they are set from long_invert. There's no reason to defer
the check/failure is there?
Thanks! |
|
Date |
User |
Action |
Args |
2007-08-23 15:46:29 | admin | link | issue1444030 messages |
2007-08-23 15:46:29 | admin | create | |
|