Message47379
Logged In: YES
user_id=80475
Patch Review
------------
On Windows using MSC 6.0, I could only reproduce about a
small speedup at around 300 bits.
While the patch is short, it adds quite a bit of complexity
to the routine. Its correctness is not self-evident or
certain. Even if correct, it is likely to encumber future
maintenance.
Unless you have important use cases and feel strongly about
it, I think this one should probably not go in.
An alternative to submit a patch that limits its scope to
factoring out the innermost switch/case. I tried that and
found that the speedup is microscopic. I suspect that that
one unpredictable branch is not much of a bottleneck. More
time is likely spent on creating z. |
|
Date |
User |
Action |
Args |
2007-08-23 15:40:55 | admin | link | issue1087418 messages |
2007-08-23 15:40:55 | admin | create | |
|