Message45531
Logged In: YES
user_id=995755
Updated the patch as follows:
1) handles no differences now in both full and context mode
(Adam discovered that it crashed when no differences in
context mode).
2) handles empty string lists (I'm pretty sure it would have
crashed had someone tried it).
3) "links" column in the middle now appears on the left as well.
4) Moved prefix argument from constructor to make_file and
make_table methods. Also made it work by default so that if
you are generating multiple tables and putting them on the
same HTML page there are no anchor name conflicts.
5) mdiff() function now is protected: _mdiff() so we are at
liberty to change the interface in the future
6) templates moved to protected global variables (still public
members of the class) so that the indenting could be
improved.
7) Improved the indenting in other areas so that the HTML is
now much more readable.
8) Inlined the special character escaping so that the xml.sax
library function is not used (this seems to have improved the
performance quite a bit).
9) Moved as many <table> attributes as possible to a style
sheet class. Adam, please review this incase I missed some.
10) Expanded test suite to cover the above changes and
made it easier to baseline.
11) Updated documentation to reflect above changes.
NOTES
N1) Raymond, you had mentioned this crashes when the
newlines are stripped. I modified the test to include stripping
and not and have found both to work without having to fix
anything. Can you duplicate what you saw and give me more
info?
N2) I've noticed the HTML does not render tabs very well (at
all). Is this OK or does anyone have any good ideas?
N3) I've attached the patch (you will also need the new file
test_difflib_expect.html). I've zipped the patched code as
well as example side by side differences of the patch. Diffs
ending with _UPDATE.html show differences between the
patched code and the last version of the patched code (what
I've done since my last posting). Diffs ending with
_PATCH.html show differences between the patched code
and what I obtained from CVS a couple weeks back:
python/python/dist/src/Lib/difflib.py -- rev 1.21
python/python/dist/src/Tools/scripts/diff.py -- rev 1.2
python/python/dist/src/Lib/test/test_difflib.py -- rev 1.10
python/python/dist/src/Doc/lib/libdifflib.tex -- rev 1.17
|
|
Date |
User |
Action |
Args |
2007-08-23 15:36:17 | admin | link | issue914575 messages |
2007-08-23 15:36:17 | admin | create | |
|