Message41847
Logged In: YES
user_id=113328
Aargh. It looks like Neal's patch is wrong - it didn't include the
changes to the files in the PC directory. Also it has a lot of
strange changes, like replacing PyEval_CallObject with
PyObject_Call - I don't see how this relates to zipfiles.
I wasted most of this morning trying to juggle too many
patches, to no avail. I think I'm going to have to revert to my
patch, get it applied to the CVS version, and upload that.
Neal, I agree with a lot of the changes you made, but they'll
need redoing - can you apply my patch to a clean checkout
and redo your tidying up?
The patch I'm uploading with this comment builds cleanly for
me on Windows 2000, and passes the supplied tests. You
need to apply the patch, then put the 2 included zipfiles in the
lib/test directory.
I'd be very grateful if someone could test this on Unix and/or
Mac, and update it where necessary. I've not tested these
platforms, but I'm assuming that Jim's original code worked
there. There are also other areas which seem strange (the big
block of deleted code in sysmodule.c worries me - but I see
no failures because of it, so I've left it unchanged) and
comments would be very helpful, but in the absence of
anything better I'm sticking with "it worked when I tried it"... |
|
Date |
User |
Action |
Args |
2007-08-23 15:18:41 | admin | link | issue645650 messages |
2007-08-23 15:18:41 | admin | create | |
|