Message416357
> tiny inline function obscures the meaning of code
Sadly I have to agree with Mark for that specific case. I've had to debug a segfault before only because the inline function implicitly cast its arguments, and it was accessing a non-existent member. If it were a macro it would access the struct member directly, and the compiler would be able to catch that and warn me before runtime.
However, for the case of _PyCFunctionObject_CAST, I'm not against it. The assert(PyCFunction_Check) pattern has genuinely helped me catch problems in the case of similar macros. |
|
Date |
User |
Action |
Args |
2022-03-30 13:52:27 | kj | set | recipients:
+ kj, vstinner, Mark.Shannon |
2022-03-30 13:52:27 | kj | set | messageid: <1648648347.46.0.427304005863.issue47164@roundup.psfhosted.org> |
2022-03-30 13:52:27 | kj | link | issue47164 messages |
2022-03-30 13:52:27 | kj | create | |
|