Message416023
I heard back from both Samuel Colvin (Pydantic) and Sebastián Ramírez (FastAPI). They said neither of them use update_wrapper with partial objects. They also took a peek in a bunch of other projects (FastAPI, Typer, SQLModel, Asyncer, SQLAlchemy, Trio, and AnyIO) and nobody was doing it.
So honestly it seems like nobody (but me!) calls update_wrapper on partial objects, and we can just fix it.
Graham, any final thoughts before we start pulling levers and merging PRs? For now I just want to fix this bug. I'm in favor of re-engineering the relevant objects so they write their own __signature__ objects, so inspect.Signature doesn't have to understand the internals of objects from other modules. But maybe we save that for another day. |
|
Date |
User |
Action |
Args |
2022-03-25 22:39:02 | larry | set | recipients:
+ larry, ping, ncoghlan, grahamd, yselivanov, BTaskaya, ofey404 |
2022-03-25 22:39:02 | larry | set | messageid: <1648247942.84.0.00123826761824.issue46761@roundup.psfhosted.org> |
2022-03-25 22:39:02 | larry | link | issue46761 messages |
2022-03-25 22:39:02 | larry | create | |
|