This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients christian.heimes, hroncok, petr.viktorin, vstinner
Date 2022-01-25.19:16:28
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1643138188.86.0.297275142359.issue46513@roundup.psfhosted.org>
In-reply-to
Content
My audioop.c change which looks to be wrong (useless):

diff --git a/Modules/audioop.c b/Modules/audioop.c
index 3aeb6f04f13..4c04b17ce7f 100644
--- a/Modules/audioop.c
+++ b/Modules/audioop.c
@@ -1948,6 +1941,13 @@ audioop_exec(PyObject* module)
 {
     audioop_state *state = get_audioop_state(module);
 
+    if (!_Py_CTYPE_IS_SIGNED(char)) {
+        PyErr_SetString(PyExc_RuntimeError,
+                        "the audioop module does not support systems "
+                        "where the char type is unsigned");
+        return -1;
+    }
+
     state->AudioopError = PyErr_NewException("audioop.error", NULL, NULL);
     if (state->AudioopError == NULL) {
         return -1;
History
Date User Action Args
2022-01-25 19:16:28vstinnersetrecipients: + vstinner, christian.heimes, petr.viktorin, hroncok
2022-01-25 19:16:28vstinnersetmessageid: <1643138188.86.0.297275142359.issue46513@roundup.psfhosted.org>
2022-01-25 19:16:28vstinnerlinkissue46513 messages
2022-01-25 19:16:28vstinnercreate