Message407981
Quoting msg407949:
> [...] We should do something like
>
> ZLIB_CFLAGS=${ZLIB_CFLAGS:-""}
> ZLIB_LIBS=${ZLIB_LIBS:-"-lz"}
>
> for all env vars.
I think we should use ${VAR-default} instead of ${VAR:-default}; we only want to override if the variable is _not_ set:
$ TEST=
$ echo ${TEST-default}
$ echo ${TEST:-default}
default
$ unset TEST
$ echo ${TEST-default}
default
$ echo ${TEST:-default}
default
> I prefer the syntax over ${ZLIB_CFLAGS:=""} because it is more obvious what
> is happening.
I agree. I also prefer `TEST=${TEST-""}` to `TEST=${TEST-}` for empty strings. |
|
Date |
User |
Action |
Args |
2021-12-07 23:05:24 | erlendaasland | set | recipients:
+ erlendaasland, christian.heimes, pablogsal, miss-islington |
2021-12-07 23:05:24 | erlendaasland | set | messageid: <1638918324.89.0.801032815948.issue45847@roundup.psfhosted.org> |
2021-12-07 23:05:24 | erlendaasland | link | issue45847 messages |
2021-12-07 23:05:24 | erlendaasland | create | |
|