This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author lemburg
Recipients brett.cannon, christian.heimes, lemburg, miss-islington, ned.deily, zach.ware
Date 2021-10-26.15:15:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <8ea2cb04-2017-152b-f5a5-f437d45baf33@egenix.com>
In-reply-to <1635257873.45.0.863843426205.issue45548@roundup.psfhosted.org>
Content
On 26.10.2021 16:17, Christian Heimes wrote:
> 
> Christian Heimes <lists@cheimes.de> added the comment:
> 
> Brett, we can use AM_CONDITIONAL() to conditionally enable/disable a feature and AC_CONFIG_FILES() to create a Modules/Setup from a template:
> 
> Example:
> 
> The conditional
> 
>     AM_CONDITIONAL([HAVE_SCPROXY], [test "$ac_sys_system" = "Darwin"])
> 
> sets HAVE_SCPROXY_FALSE and HAVE_NIS_SCPROXY based on the check.

I think it would be more helpful (and generate a lot fewer such
macros), if we'd just test for platforms and then use those in the
Setup.in template.

Some other things:

I saw that you stripped off lots of -I and -L options from the Setup
lines. Are those now unconditionally taken from somewhere else,
without possibility to override them ?

You also removed the structure of the listings, which makes things
like dependencies between e.g. _multibytecodec and the CJK codecs
unclear, the notes about audio, the comments on building the _md5
and sha* modules, etc.

Since Setup is a (potentially) hand edited file, it's good to leave
as much useful information in that file as possible, to not
accidentally create setups which don't work and to have references
which may help in finding the right compile options.
History
Date User Action Args
2021-10-26 15:15:44lemburgsetrecipients: + lemburg, brett.cannon, christian.heimes, ned.deily, zach.ware, miss-islington
2021-10-26 15:15:44lemburglinkissue45548 messages
2021-10-26 15:15:44lemburgcreate