➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients lukasz.langa, miss-islington, serhiy.storchaka, vstinner
Date 2021-09-20.07:56:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1632124560.4.0.100336507249.issue45187@roundup.psfhosted.org>
In-reply-to
Content 
> bpo-45187: Collect test_socket tests using unittest (GH-28317)

Nice enhancement! Thanks.

> self.addCleanup(thread.join, self.timeout)

I suggest to use test.support.threading_helper.join_thread() to avoid blocking if the thread raises an exception or never completes. The function has a timeout with a reasonable default value (adapted per buildbot).
History
Date User Action Args
2021-09-20 07:56:00vstinnersetrecipients: + vstinner, lukasz.langa, serhiy.storchaka, miss-islington
2021-09-20 07:56:00vstinnersetmessageid: <1632124560.4.0.100336507249.issue45187@roundup.psfhosted.org>
2021-09-20 07:56:00vstinnerlinkissue45187 messages
2021-09-20 07:56:00vstinnercreate