Author eric.snow
Recipients BTaskaya, Mark.Shannon, brandtbucher, brett.cannon, eric.snow, gvanrossum, indygreg, larry, lemburg, methane, nascheme, ronaldoussoren, shihai1991
Date 2021-09-01.16:35:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CALFfu7D9Jvk6tRy+51gJjzfpWLCHTmN909fc-uAePxAT861krA@mail.gmail.com>
In-reply-to <1630469128.22.0.684725505166.issue45020@roundup.psfhosted.org>
Content
On Tue, Aug 31, 2021 at 10:05 PM Inada Naoki <report@bugs.python.org> wrote:
> I don't want all frozen header files to be committed in git repository.
> Can't we just build them during build process?

That's a good point (and an interesting one).  Only two of the frozen
modules are necessary (_frozen_importlib_external and
_frozen_importlib_external, to bootstrap the import system).  So for
those two it makes sense to have them in the git repository.

For all the rest it isn't necessary.  The only advantage is that
contributors don't have to think about them and they will be
guaranteed to be there.  However, if someone clones the repo they have
to build Python, so the frozen modules will get created anyway at that
point.

So I'm fine with not committing all those modules.  This will require
that all those files be added to the .gitignore file.  (I'll update my
PR accordingly.)

-eric
History
Date User Action Args
2021-09-01 16:35:43eric.snowsetrecipients: + eric.snow, lemburg, gvanrossum, brett.cannon, nascheme, ronaldoussoren, larry, methane, Mark.Shannon, indygreg, brandtbucher, BTaskaya, shihai1991
2021-09-01 16:35:43eric.snowlinkissue45020 messages
2021-09-01 16:35:43eric.snowcreate