Author vinay.sajip
Recipients Harry-Lees, aeg, vinay.sajip
Date 2021-08-02.07:48:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1627890515.36.0.249535372299.issue44186@roundup.psfhosted.org>
In-reply-to
Content
OK, I get it now :-)

See my comments on the PR - I think the renaming strategy might need rethinking in the presence of a "namer" routine being set. See bpo-43344, bpo-44753. This area (TimedRotatingFileHandler) is unfortunately not yet well tested, because you would need mocking to avoid delays in test runs. But ideally, we would test in the absence and presence of a renamer routine that moved the ".log" to the end of the filename.
History
Date User Action Args
2021-08-02 07:48:35vinay.sajipsetrecipients: + vinay.sajip, Harry-Lees, aeg
2021-08-02 07:48:35vinay.sajipsetmessageid: <1627890515.36.0.249535372299.issue44186@roundup.psfhosted.org>
2021-08-02 07:48:35vinay.sajiplinkissue44186 messages
2021-08-02 07:48:35vinay.sajipcreate