Author serhiy.storchaka
Recipients corona10, gvanrossum, kj, serhiy.storchaka
Date 2021-07-16.17:32:03
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1626456723.37.0.550086249638.issue44654@roundup.psfhosted.org>
In-reply-to
Content
> Yeah I noticed it re-lookups __module__ unnecessarily multiple times for the same type.

Actually I thought about this change, but did not implement it. Because it does not look performance critical, and future versions will likely do different tests (for example, testing the existence of special attribute, or check against lazily imported and cached classes from the typing module). Also, the test for TypeVar can be shared between genericaliasobject.c and unionobject.c.

It is mostly simple clean up, a line here, two lines there. genericaliasobject.c and unionobject.c could be merged in a single file, because they share several functions not used anywhere more. We perhaps merge them if more C implementations for typing be added in future.
History
Date User Action Args
2021-07-16 17:32:03serhiy.storchakasetrecipients: + serhiy.storchaka, gvanrossum, corona10, kj
2021-07-16 17:32:03serhiy.storchakasetmessageid: <1626456723.37.0.550086249638.issue44654@roundup.psfhosted.org>
2021-07-16 17:32:03serhiy.storchakalinkissue44654 messages
2021-07-16 17:32:03serhiy.storchakacreate