➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author erlendaasland
Recipients erlendaasland, pablogsal
Date 2021-06-15.23:22:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1623799349.31.0.598300171565.issue44430@roundup.psfhosted.org>
In-reply-to
Content 
The threading tests (ThreadTests) in Lib/sqlite3/test/dbapi.py has a lot of code duplication, and none of the test methods use the test.support.threading_helper.reap_threads helper. Also, some branches are not covered by this test class. Suggesting the following:

1. Rewrite ThreadTests with a _run_test() helper method that does the heavy lifting
2. Add test.support.threading_helper.reap_threads to _run_test()
3. Use _run_test() in all threading tests
4. Add test case for sqlite3.Connection.set_trace_callback
5. Add test case for sqlite3.Connection.create_collation
History
Date User Action Args
2021-06-15 23:22:29erlendaaslandsetrecipients: + erlendaasland, pablogsal
2021-06-15 23:22:29erlendaaslandsetmessageid: <1623799349.31.0.598300171565.issue44430@roundup.psfhosted.org>
2021-06-15 23:22:29erlendaaslandlinkissue44430 messages
2021-06-15 23:22:29erlendaaslandcreate