Author lunixbochs2
Recipients Dennis Sweeney, SD, eryksun, lunixbochs2, miss-islington, ned.deily, paul.moore, pitrou, steve.dower, tim.golden, vstinner, zach.ware
Date 2021-06-14.18:37:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1623695833.02.0.0461741900881.issue41299@roundup.psfhosted.org>
In-reply-to
Content
> Do you think that pytime.c has the bug? I don't think so.

No, a misaligned stack would be an issue in the caller or compiler, not pytime.c. I have hit misaligned stack in practice, but it should be rare enough to check on init only.

> In theory yes, in practice we got zero error reports. So it sounds like it cannot happen.
> I don't think that it's a good practice to start to add checks in all functions using a clock "just in case" the clock might fail.

My read is that as long as we're not confident enough to remove those checks from pytime.c, a caller should assume they're reachable. If the pytime checks need to stay, adding a Windows only pytime init check to make sure that locks won't deadlock sounds fine to me.
History
Date User Action Args
2021-06-14 18:37:13lunixbochs2setrecipients: + lunixbochs2, paul.moore, pitrou, vstinner, tim.golden, ned.deily, zach.ware, eryksun, steve.dower, miss-islington, Dennis Sweeney, SD
2021-06-14 18:37:13lunixbochs2setmessageid: <1623695833.02.0.0461741900881.issue41299@roundup.psfhosted.org>
2021-06-14 18:37:13lunixbochs2linkissue41299 messages
2021-06-14 18:37:12lunixbochs2create