Message395765
Both this ticket and #19094 started from one method in urllib.parse and then generalized a proposal for the rest of the submodule to move away from duck-typing and to instead raise TypeErrors (or at least some error) for invalid types. The attached PR does that. But it broke pip, which was passing None to the `fragment` argument of `urlunsplit()`.
In a blaze of efficiency, Pip already merged my fix, but since the CPython test suite depends on the current version of pip -- perhaps there's an argument for at least raising a deprecation warning for ``None`` and then converting to '' or b''? In any case, green CI makes patches more reviewable, so I'm inclined to add such a warning/conversion for now and then see how feedback goes. Cheers, all.
BTW: perhaps we can close this as dupe of #19094? |
|
Date |
User |
Action |
Args |
2021-06-13 22:22:18 | jacobtylerwalls | set | recipients:
+ jacobtylerwalls, orsenthil, r.david.murray, martin.panter, serhiy.storchaka, ztane, demian.brecht, luiz.poleto |
2021-06-13 22:22:18 | jacobtylerwalls | set | messageid: <1623622938.52.0.371232483657.issue22234@roundup.psfhosted.org> |
2021-06-13 22:22:18 | jacobtylerwalls | link | issue22234 messages |
2021-06-13 22:22:18 | jacobtylerwalls | create | |
|