Author barneygale
Recipients barneygale
Date 2021-05-14.18:28:58
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1621016938.4.0.46024543706.issue44136@roundup.psfhosted.org>
In-reply-to
Content
Following bpo-39899, bpo-43757 and bpo-43012, `pathlib._Flavour` and its subclasses are looking a bit pointless.

The implementations of `is_reserved()` and `make_uri()` (~`as_uri()`) can be readily moved to into `PurePosixPath` and `PureWindowsPath`, which removes some indirection. This follows the pattern of OS-specific stuff in `PosixPath` and `WindowsPath`.

The remaining methods, such as `splitroot()`, can be pulled into `Pure*Path` with an underscore prefix.

I'm generally a believer in composition over inheritance, but in this case `_Flavour` seems too small and too similar to `PurePath` to separate out into 3 extra classes.

There should be no impact on public APIs or performance.
History
Date User Action Args
2021-05-14 18:28:58barneygalesetrecipients: + barneygale
2021-05-14 18:28:58barneygalesetmessageid: <1621016938.4.0.46024543706.issue44136@roundup.psfhosted.org>
2021-05-14 18:28:58barneygalelinkissue44136 messages
2021-05-14 18:28:58barneygalecreate