Message393685
Following bpo-39899, bpo-43757 and bpo-43012, `pathlib._Flavour` and its subclasses are looking a bit pointless.
The implementations of `is_reserved()` and `make_uri()` (~`as_uri()`) can be readily moved to into `PurePosixPath` and `PureWindowsPath`, which removes some indirection. This follows the pattern of OS-specific stuff in `PosixPath` and `WindowsPath`.
The remaining methods, such as `splitroot()`, can be pulled into `Pure*Path` with an underscore prefix.
I'm generally a believer in composition over inheritance, but in this case `_Flavour` seems too small and too similar to `PurePath` to separate out into 3 extra classes.
There should be no impact on public APIs or performance. |
|
Date |
User |
Action |
Args |
2021-05-14 18:28:58 | barneygale | set | recipients:
+ barneygale |
2021-05-14 18:28:58 | barneygale | set | messageid: <1621016938.4.0.46024543706.issue44136@roundup.psfhosted.org> |
2021-05-14 18:28:58 | barneygale | link | issue44136 messages |
2021-05-14 18:28:58 | barneygale | create | |
|