Author joemarshall
Recipients joemarshall
Date 2021-05-12.12:46:01
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1620823561.64.0.419692119769.issue44114@roundup.psfhosted.org>
In-reply-to
Content
There's a couple of wrong function signatures in dictobject.c,

dictkeys_reversed and dictitems_reversed are defined as single arg functions like so: PyObject *(PyObject *), and are then passed around and called as PyCFunctions, which should be PyObject *(PyObject *self,PyObject *args). dictvalues_reversed is correct.

This works fine on most C compilers as the extra arg is just ignored, but on things that use strict function pointer type checking (e.g. webassembly), it crashes (and hence any of the tests that happen to use these functions fails, which is a surprising number)

I've got a fix in my pyodide repo, which I'll chuck in as a pull request on github.
History
Date User Action Args
2021-05-12 12:46:01joemarshallsetrecipients: + joemarshall
2021-05-12 12:46:01joemarshallsetmessageid: <1620823561.64.0.419692119769.issue44114@roundup.psfhosted.org>
2021-05-12 12:46:01joemarshalllinkissue44114 messages
2021-05-12 12:46:01joemarshallcreate