This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author roryyorke
Recipients roryyorke
Date 2021-05-08.08:05:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1620461112.36.0.942809733217.issue44074@roundup.psfhosted.org>
In-reply-to
Content
I'm probably missing something, but "master" seems hard-coded into patchcheck.py, and I couldn't find any related issues on bpo.

Checked on branch off 42fcad2.

When I ran patchcheck:

    rory@rory-latitude:~/src/cpython$ ./python Tools/scripts/patchcheck.py
    Getting base branch for PR ... origin/master
    Getting the list of files that have been added/changed ... fatal: ambiguous argument 'origin/master': unknown revision or path not in the working tree.
    Use '--' to separate paths from revisions, like this:
    'git <command> [<revision>...] -- [<file>...]'
    0 files
    <snip>

The obvious offender is line 81 of Tools/scripts/patchcheck.py:

        base_branch = "master"

Changing this to "main" results in useful output, but I imagine one
would want to check for both "master" and "main" for a while yet?
History
Date User Action Args
2021-05-08 08:05:12roryyorkesetrecipients: + roryyorke
2021-05-08 08:05:12roryyorkesetmessageid: <1620461112.36.0.942809733217.issue44074@roundup.psfhosted.org>
2021-05-08 08:05:12roryyorkelinkissue44074 messages
2021-05-08 08:05:12roryyorkecreate