Author malin
Recipients gregory.p.smith, malin, methane
Date 2021-04-30.02:55:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1619751342.81.0.963259131164.issue41486@roundup.psfhosted.org>
In-reply-to
Content
Found a backward incompatible behavior. 

Before the patch, in 64-bit build, zlib module allows the initial size > UINT32_MAX.
It creates a bytes object, and uses a sliding window to deal with the UINT32_MAX limit:
https://github.com/python/cpython/blob/v3.9.4/Modules/zlibmodule.c#L183

After the patch, when init_size > UINT32_MAX, it raises a ValueError.

PR 25738 fixes this backward incompatibility.
If the initial size > UINT32_MAX, it clamps to UINT32_MAX, rather than raising an exception.

Moreover, if you don't mind, I would like to take this opportunity to rename the wrapper functions from Buffer_* to OutputBuffer_*, so that the readers can easily distinguish between input buffer and output buffer.
If you don't think it's necessary, you may merge PR 25738 as is.
History
Date User Action Args
2021-04-30 02:55:42malinsetrecipients: + malin, gregory.p.smith, methane
2021-04-30 02:55:42malinsetmessageid: <1619751342.81.0.963259131164.issue41486@roundup.psfhosted.org>
2021-04-30 02:55:42malinlinkissue41486 messages
2021-04-30 02:55:42malincreate