Hi,

I think that using mock.patch to fix the problem is fine. I personally
haven't encountered this problem in the past years, so whatever you decide
is fine by me.

Thanks!
Noam

On Mon, Apr 26, 2021 at 10:08 AM Sergey B Kirpichev <report@bugs.python.org>
wrote:

>
> Sergey B Kirpichev <skirpichev@gmail.com> added the comment:
>
> Tim, lets decide on this simple issue.
>
> To me, https://bugs.python.org/issue8048 was obviously a bad thing.
> While it "fixes" one application, which customize sys.displayhook in a
> strange way - it break testing almost everyone, which do sys.displayhook
> customization.  See e.g.
> https://github.com/sympy/sympy/blob/master/conftest.py or
> https://github.com/diofant/diofant/blob/master/conftest.py.  BTW, SymPy
> is far more popular library than dreampie, which is py2-only and looks
> unmaintained.
>
> Last, but not least - introduced doctest's behaviour wasn't documented.
> It break things in a surprising way and do this silently...  There is a
> documentation issue if you decide to keep this "feature".
>
> Noam, what do you think about fixing your problem with mock.patch?
>
>     >>> import sys
>     >>> from unittest.mock import patch
>     >>> with patch('sys.displayhook', sys.__displayhook__):
>     ...     doctest.testmod()
>
> Tentative patch attached.
>
> ----------
> keywords: +patch
> Added file: https://bugs.python.org/file49985/doctest-displayhook.diff
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <https://bugs.python.org/issue26092>
> _______________________________________
>