Author gregory.p.smith
Recipients gregory.p.smith, malin, methane
Date 2021-04-11.19:57:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1618171076.35.0.163574951646.issue41486@roundup.psfhosted.org>
In-reply-to
Content
I left some review comments on the PR.  I like the algorithm being used.  

I don't really _like_ that this is a .h file acting as a C template to inject effectively the same static code into each module that wants to use it...  Which I think is the concern Victor is expressing in a comment above.

I could live with this PR as is because it is at least easy to maintain.  But I anticipate we'll want to refactor it in the future to be shared code instead of a copy compiled per module.

This is the kind of thing that also makes sense to be usable outside of just these modules.  Compression modules for the other popular compression algorithms currently not in the stdlib but available on PyPI shouldn't need to reinvent this wheel on their own without reason. (lzo, brotli, zstandard, no doubt others...)

It is also worth looking at those to see if they've already implemented something like this and how it differs.
History
Date User Action Args
2021-04-11 19:57:56gregory.p.smithsetrecipients: + gregory.p.smith, methane, malin
2021-04-11 19:57:56gregory.p.smithsetmessageid: <1618171076.35.0.163574951646.issue41486@roundup.psfhosted.org>
2021-04-11 19:57:56gregory.p.smithlinkissue41486 messages
2021-04-11 19:57:56gregory.p.smithcreate