Author Quentin.Pradet
Recipients Quentin.Pradet, christian.heimes
Date 2021-03-17.06:01:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1615960900.79.0.877722032953.issue43522@roundup.psfhosted.org>
In-reply-to
Content
Thank you for the quick fix! 🙏 Both the reproducer and the urllib3 test suite run fine with this change.

However, we can't trust `HAS_NEVER_CHECK_COMMON_NAME` anymore, because it will be True in Python versions where `hostname_checks_common_name` does not work. Is it possible to have, uh, `REALLY_HAS_NEVER_CHECK_COMMON_NAME_I_PROMISE` or something like that? :D It could even be private. Otherwise, we will only be able to use `hostname_checks_common_name` in Python 3.10.0a7+.
History
Date User Action Args
2021-03-17 06:01:40Quentin.Pradetsetrecipients: + Quentin.Pradet, christian.heimes
2021-03-17 06:01:40Quentin.Pradetsetmessageid: <1615960900.79.0.877722032953.issue43522@roundup.psfhosted.org>
2021-03-17 06:01:40Quentin.Pradetlinkissue43522 messages
2021-03-17 06:01:40Quentin.Pradetcreate