Author Sergey.Kirpichev
Recipients Sergey.Kirpichev, asmeurer, mark.dickinson, rhettinger
Date 2021-03-07.11:45:24
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1615117524.97.0.356782517322.issue43420@roundup.psfhosted.org>
In-reply-to
Content
> I'd prefer to keep the code simplicity

It's not going to be complicated so much and algorithms are well known,
but I see your point.

> and the speed for small inputs here

Speed loss is not so big, 10-20%.

> Python's needs aren't the same as SymPy's needs or SAGE's needs

So, for which needs it will serve?

Sorry, I can't suggest an application, which does use builtin
Fraction's (not sure if even SAGE uses them, as a fallback).  SymPy doesn't,
for sure (but it could - it's PythonRational class uses same optimizations,
except for g == 1 branches in _add/_sub, I think).

There is one exception I've found: stdlib's statistics module uses Fraction's
in the _sum() helper, exactly in a paradigm "sum a lot of values".

> not all of the fractions.Fraction use-cases involve summing lots of values with incompatible denominators.

No need for a lots of values (i.e. 1000): denominator of the sum will grow very fast, that
why modern CAS use modular GCD algorithms, for example.

> Could you give some idea of the crossover point for a single addition?

$ ./python -m timeit -r11 -s 'from fractions import Fraction as F' -s 'a=F(10,31011021112)' -s 'b=F(86,11011021115)' 'a + b'
20000 loops, best of 11: 12.4 usec per loop
$ ./python -m timeit -r11 -s 'from patched import Fraction as F' -s 'a=F(10,31011021112)' -s 'b=F(86,11011021115)' 'a + b'
20000 loops, best of 11: 12.5 usec per loop
History
Date User Action Args
2021-03-07 11:45:25Sergey.Kirpichevsetrecipients: + Sergey.Kirpichev, rhettinger, mark.dickinson, asmeurer
2021-03-07 11:45:24Sergey.Kirpichevsetmessageid: <1615117524.97.0.356782517322.issue43420@roundup.psfhosted.org>
2021-03-07 11:45:24Sergey.Kirpichevlinkissue43420 messages
2021-03-07 11:45:24Sergey.Kirpichevcreate