Message387859
> There are three calls of pysqlite_statement_reset() in _pysqlite_query_execute()
Yes, but only two before the cache is queried.
> So additional call of pysqlite_statement_reset() does not harm.
That's true, but removing redundant code makes it easier to read and maintain, IMO.
> On other hand removing it can introduce race condition.
How?
> Maybe the code could be rewritten in more explicit way and call pysqlite_statement_reset() only when it is necessary
Most of _pysqlite_query_execute() could be rewritten in order to make the code clearer. An alternative is to clean it up part by part. |
|
Date |
User |
Action |
Args |
2021-03-01 12:38:31 | erlendaasland | set | recipients:
+ erlendaasland, berker.peksag, serhiy.storchaka |
2021-03-01 12:38:31 | erlendaasland | set | messageid: <1614602311.06.0.658123980375.issue43350@roundup.psfhosted.org> |
2021-03-01 12:38:31 | erlendaasland | link | issue43350 messages |
2021-03-01 12:38:31 | erlendaasland | create | |
|