This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author erlendaasland
Recipients berker.peksag, erlendaasland, serhiy.storchaka
Date 2021-03-01.12:38:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
> There are three calls of pysqlite_statement_reset() in _pysqlite_query_execute()

Yes, but only two before the cache is queried.

> So additional call of pysqlite_statement_reset() does not harm.

That's true, but removing redundant code makes it easier to read and maintain, IMO.

> On other hand removing it can introduce race condition.


> Maybe the code could be rewritten in more explicit way and call pysqlite_statement_reset() only when it is necessary

Most of _pysqlite_query_execute() could be rewritten in order to make the code clearer. An alternative is to clean it up part by part.
Date User Action Args
2021-03-01 12:38:31erlendaaslandsetrecipients: + erlendaasland, berker.peksag, serhiy.storchaka
2021-03-01 12:38:31erlendaaslandsetmessageid: <>
2021-03-01 12:38:31erlendaaslandlinkissue43350 messages
2021-03-01 12:38:31erlendaaslandcreate