This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients berker.peksag, erlendaasland, serhiy.storchaka
Date 2021-03-01.12:15:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1614600906.35.0.225535353108.issue43350@roundup.psfhosted.org>
In-reply-to
Content
There are three calls of pysqlite_statement_reset() in _pysqlite_query_execute(). And all three of them can be called with the same statement object. But repeated calls are no-ops because pysqlite_statement_reset() clears flag in_use and calls sqlite3_reset() only if it was set before. So additional call of pysqlite_statement_reset() does not harm. You can call it as many times as you want. On other hand removing it can introduce race condition.

Maybe the code could be rewritten in more explicit way and call pysqlite_statement_reset() only when it is necessary, but for now I don't think that just removing one call will make the code better.
History
Date User Action Args
2021-03-01 12:15:06serhiy.storchakasetrecipients: + serhiy.storchaka, berker.peksag, erlendaasland
2021-03-01 12:15:06serhiy.storchakasetmessageid: <1614600906.35.0.225535353108.issue43350@roundup.psfhosted.org>
2021-03-01 12:15:06serhiy.storchakalinkissue43350 messages
2021-03-01 12:15:05serhiy.storchakacreate