Author erlendaasland
Recipients berker.peksag, erlendaasland, serhiy.storchaka
Date 2021-02-22.10:06:47
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1613988407.68.0.840775188908.issue43294@roundup.psfhosted.org>
In-reply-to
Content
In Modules/_sqlite/connection.c:
pysqlite_connection_commit_impl(), pysqlite_connection_rollback_impl(), and _pysqlite_connection_begin() all call sqlite3_prepare_v2() with the fourth parameter (pzTail) set. This (output) parameter is never used, we can safely remove the tail variables, and just call sqlite3_prepare_v2() with NULL as the fourth parameter.


Also, there's a lot of code duplication here. A support function could help simplify this, but that's out of scope.
History
Date User Action Args
2021-02-22 10:06:47erlendaaslandsetrecipients: + erlendaasland, berker.peksag, serhiy.storchaka
2021-02-22 10:06:47erlendaaslandsetmessageid: <1613988407.68.0.840775188908.issue43294@roundup.psfhosted.org>
2021-02-22 10:06:47erlendaaslandlinkissue43294 messages
2021-02-22 10:06:47erlendaaslandcreate