Author erlendaasland
Recipients berker.peksag, erlendaasland
Date 2021-02-19.10:45:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1613731536.26.0.545379664561.issue43267@roundup.psfhosted.org>
In-reply-to
Content
The type checks at the start of pysqlite_statement_bind_parameter() are redundant:
We first check for exact types (*_CheckExact()), and then we check again for exact or subtyped versions (*_Check()).

(Adding to the redundantness: the result of this if..else "switch statement" is then reused as the expression in the subsequent switch statement.)

Suggesting to remove the redundant checks and merge the two switch statements.
History
Date User Action Args
2021-02-19 10:45:36erlendaaslandsetrecipients: + erlendaasland, berker.peksag
2021-02-19 10:45:36erlendaaslandsetmessageid: <1613731536.26.0.545379664561.issue43267@roundup.psfhosted.org>
2021-02-19 10:45:36erlendaaslandlinkissue43267 messages
2021-02-19 10:45:35erlendaaslandcreate