Message 386508 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	methane
Recipients	Marcin Kowalczyk, docs@python, ezio.melotti, methane, vstinner
Date	2021-02-05.03:53:56
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1612497236.86.0.523813470935.issue35295@roundup.psfhosted.org>
In-reply-to

Content
> 1a. Declare both functions equally acceptable. Remove comments claiming that PyUnicode_AsUTF8AndSize() should be avoided. > > 1b. 1a, and change the implementation of PyUnicode_AsUTF8AndSize() to avoid allocating the string twice if it needs to be materialized, so that PyUnicode_AsUTF8AndSize() is never significantly slower than PyUnicode_AsUTF8String(). I think 1b is the best approach. PyUnicode_AsUTF8AndSize() is optimized already. See GH-18327. And it becomes limited API. See bpo-41784. So we should just remove the outdated comments.

> 1a. Declare both functions equally acceptable. Remove comments claiming that PyUnicode_AsUTF8AndSize() should be avoided.
>
> 1b. 1a, and change the implementation of PyUnicode_AsUTF8AndSize() to avoid allocating the string twice if it needs to be materialized, so that PyUnicode_AsUTF8AndSize() is never significantly slower than PyUnicode_AsUTF8String().

I think 1b is the best approach.

PyUnicode_AsUTF8AndSize() is optimized already. See GH-18327.
And it becomes limited API. See bpo-41784.

So we should just remove the outdated comments.

History
Date	User	Action	Args
2021-02-05 03:53:57	methane	set	recipients: + methane, vstinner, ezio.melotti, docs@python, Marcin Kowalczyk
2021-02-05 03:53:56	methane	set	messageid: <1612497236.86.0.523813470935.issue35295@roundup.psfhosted.org>
2021-02-05 03:53:56	methane	link	issue35295 messages
2021-02-05 03:53:56	methane	create