Message384518
TBH as I said in the now-closed PR, using a NullSocket seems overkill. As mentioned in msg359594, it seems to make more sense to assign a socket attribute to None early in the constructor. If an error occurs during socket creation, the socket attribute will remain at None. When closing, just ensure the socket attribute isn't None before trying to close it. This mirrors what SocketHandler does. |
|
Date |
User |
Action |
Args |
2021-01-06 17:30:15 | vinay.sajip | set | recipients:
+ vinay.sajip, ronaldoussoren, jaraco, ned.deily, youtux, erlendaasland, alanr |
2021-01-06 17:30:15 | vinay.sajip | set | messageid: <1609954215.84.0.324277608336.issue38780@roundup.psfhosted.org> |
2021-01-06 17:30:15 | vinay.sajip | link | issue38780 messages |
2021-01-06 17:30:15 | vinay.sajip | create | |
|