Message 383906 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	shihai1991
Recipients	Jim.Jewett, petr.viktorin, shihai1991, vstinner
Date	2020-12-28.17:19:24
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1609175964.89.0.294236172281.issue30963@roundup.psfhosted.org>
In-reply-to

Content
> #define XxoObject_CheckExact(v) (Py_TYPE(v) == &Xxo_Type) `#define Xxo_CheckExact(obj) Py_IS_TYPE(obj, &Xxo_Type)` would be better to hide details now. > #define XxoObject_Check(v) PyObject_TypeCheck(v, &Xxo_Type) +1 I think the annotation will worth to be updaetd. https://github.com/python/cpython/blob/master/Modules/xxlimited.c#L76

> #define XxoObject_CheckExact(v) (Py_TYPE(v) == &Xxo_Type)
`#define Xxo_CheckExact(obj) Py_IS_TYPE(obj, &Xxo_Type)` would be better to hide details now.

> #define XxoObject_Check(v) PyObject_TypeCheck(v, &Xxo_Type)
+1

I think the annotation will worth to be updaetd.
https://github.com/python/cpython/blob/master/Modules/xxlimited.c#L76

History
Date	User	Action	Args
2020-12-28 17:19:24	shihai1991	set	recipients: + shihai1991, vstinner, petr.viktorin, Jim.Jewett
2020-12-28 17:19:24	shihai1991	set	messageid: <1609175964.89.0.294236172281.issue30963@roundup.psfhosted.org>
2020-12-28 17:19:24	shihai1991	link	issue30963 messages
2020-12-28 17:19:24	shihai1991	create