Message 383885 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	chanke
Recipients	FreeSandwiches, chanke
Date	2020-12-28.07:45:44
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1609141544.52.0.414896395987.issue41354@roundup.psfhosted.org>
In-reply-to

Content
I understand that you are reluctant to change existing code. But for me as a sysadmin, the current behavior doesn't make sense for two reasons: * st.st_size is part of _sig. why would you do a deep compare if the two files have a different length ? * comparing thousands of files, a proper shallow-only compare is required, since it takes a long time to compare large files (especially when they are migrated to a tape-backend), so a silent-fallback to a deep-compare is not good.

I understand that you are reluctant to change existing code.
But for me as a sysadmin, the current behavior doesn't make sense for two reasons:

* st.st_size is part of _sig.  why would you do a deep compare if  the two files have a different length ?

* comparing thousands of files, a proper shallow-only compare is required, since it takes a long time to compare large files (especially when they are migrated to a tape-backend), so a silent-fallback to a deep-compare is not good.

History
Date	User	Action	Args
2020-12-28 07:45:44	chanke	set	recipients: + chanke, FreeSandwiches
2020-12-28 07:45:44	chanke	set	messageid: <1609141544.52.0.414896395987.issue41354@roundup.psfhosted.org>
2020-12-28 07:45:44	chanke	link	issue41354 messages
2020-12-28 07:45:44	chanke	create