Message 383838 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	corona10
Recipients	berker.peksag, corona10, erlendaasland, serhiy.storchaka
Date	2020-12-27.08:11:58
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1609056718.52.0.719197971794.issue42755@roundup.psfhosted.org>
In-reply-to

Content
Docs says that pages default value is 0 but the implementation is -1 docs: https://docs.python.org/3/library/sqlite3.html#sqlite3.Connection.backup impl: https://github.com/python/cpython/blob/f4507231e3f0cf8827cec5592571ce371c6813e8/Modules/_sqlite/connection.c#L1565 But the behavior will be the same and if the pages is set to zero, we update this value to -1. https://github.com/python/cpython/blob/f4507231e3f0cf8827cec5592571ce371c6813e8/Modules/_sqlite/connection.c#L1625 So IMHO, I'd like to suggest updating the docs rather than updating the implementation.

Docs says that pages default value is 0 but the implementation is -1

docs: https://docs.python.org/3/library/sqlite3.html#sqlite3.Connection.backup
impl: https://github.com/python/cpython/blob/f4507231e3f0cf8827cec5592571ce371c6813e8/Modules/_sqlite/connection.c#L1565

But the behavior will be the same and if the pages is set to zero, we update this value to -1.
https://github.com/python/cpython/blob/f4507231e3f0cf8827cec5592571ce371c6813e8/Modules/_sqlite/connection.c#L1625

So IMHO, I'd like to suggest updating the docs rather than updating the implementation.

History
Date	User	Action	Args
2020-12-27 08:11:58	corona10	set	recipients: + corona10, berker.peksag, serhiy.storchaka, erlendaasland
2020-12-27 08:11:58	corona10	set	messageid: <1609056718.52.0.719197971794.issue42755@roundup.psfhosted.org>
2020-12-27 08:11:58	corona10	link	issue42755 messages
2020-12-27 08:11:58	corona10	create