Author vstinner
Recipients Jim Fasarakis-Hilliard, amaury.forgeotdarc, christian.heimes, corona10, eric.snow, erlendaasland, isoschiz, koubaa, kylotan, lukasz.langa, miss-islington, orsenthil, pconnell, petr.viktorin, phsilva, python-dev, santoso.wijaya, serhiy.storchaka, shihai1991, tlesher, vstinner, ysj.ray
Date 2020-12-26.10:52:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1608979959.15.0.92636829336.issue1635741@roundup.psfhosted.org>
In-reply-to
Content 
I checked for ^.*tp_new.*=.*NULL regex in "git log -p" command output. I checked all commits up to May 8 2016, the commit which added:

+    ((PyTypeObject *)v)->tp_new = NULL;

I met "FlagsType.tp_new = NULL;" multiple times since the code moved multiple times.

Apart of the issue in _curses_panel.panel, I didn't see any other removal by mistake. In this issue, the work started in 2019, so I consider that it's ok. No other tp_new=NULL was removed by mistake.

Again, if tp_new=NULL is used, I suggest to write a function test to ensure that it's not possible to instanciate the type.
History
Date User Action Args
2020-12-26 10:52:39vstinnersetrecipients: + vstinner, amaury.forgeotdarc, orsenthil, kylotan, christian.heimes, tlesher, phsilva, petr.viktorin, ysj.ray, santoso.wijaya, lukasz.langa, python-dev, eric.snow, serhiy.storchaka, pconnell, isoschiz, Jim Fasarakis-Hilliard, corona10, miss-islington, shihai1991, erlendaasland, koubaa
2020-12-26 10:52:39vstinnersetmessageid: <1608979959.15.0.92636829336.issue1635741@roundup.psfhosted.org>
2020-12-26 10:52:39vstinnerlinkissue1635741 messages
2020-12-26 10:52:39vstinnercreate