Message383801
I checked for ^.*tp_new.*=.*NULL regex in "git log -p" command output. I checked all commits up to May 8 2016, the commit which added:
+ ((PyTypeObject *)v)->tp_new = NULL;
I met "FlagsType.tp_new = NULL;" multiple times since the code moved multiple times.
Apart of the issue in _curses_panel.panel, I didn't see any other removal by mistake. In this issue, the work started in 2019, so I consider that it's ok. No other tp_new=NULL was removed by mistake.
Again, if tp_new=NULL is used, I suggest to write a function test to ensure that it's not possible to instanciate the type. |
|
Date |
User |
Action |
Args |
2020-12-26 10:52:39 | vstinner | set | recipients:
+ vstinner, amaury.forgeotdarc, orsenthil, kylotan, christian.heimes, tlesher, phsilva, petr.viktorin, ysj.ray, santoso.wijaya, lukasz.langa, python-dev, eric.snow, serhiy.storchaka, pconnell, isoschiz, Jim Fasarakis-Hilliard, corona10, miss-islington, shihai1991, erlendaasland, koubaa |
2020-12-26 10:52:39 | vstinner | set | messageid: <1608979959.15.0.92636829336.issue1635741@roundup.psfhosted.org> |
2020-12-26 10:52:39 | vstinner | link | issue1635741 messages |
2020-12-26 10:52:39 | vstinner | create | |
|