This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients ammar2, p-ganssle, serhiy.storchaka
Date 2020-12-16.19:08:22
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1608145702.5.0.555023615679.issue42660@roundup.psfhosted.org>
In-reply-to
Content
I propose to change types of function parameters and local variables. In any case the constructor checks the range of parameters, so there is no problem with packing them into compact structure.

This will help to avoid errors of implicit conversion between different integer types. Also it can help to avoid code duplication in parsing integers of different size and signedness.

Adding a static assertion about the signedness of uint8_t looks meaningless to me.
History
Date User Action Args
2020-12-16 19:08:22serhiy.storchakasetrecipients: + serhiy.storchaka, ammar2, p-ganssle
2020-12-16 19:08:22serhiy.storchakasetmessageid: <1608145702.5.0.555023615679.issue42660@roundup.psfhosted.org>
2020-12-16 19:08:22serhiy.storchakalinkissue42660 messages
2020-12-16 19:08:22serhiy.storchakacreate