Author terry.reedy
Recipients eryksun, guy.linton, paul.moore, serhiy.storchaka, steve.dower, terry.reedy, tim.golden, vstinner, xtreak, zach.ware
Date 2020-12-08.14:06:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1607436362.71.0.827254772223.issue37945@roundup.psfhosted.org>
In-reply-to
Content
This seemingly useless test is the only test failure for me with installed 3.9.1.  Why keep it, at least on Windows.

The failure with "locale.Error: unsupported locale setting" is not limited to Windows.  #25191 and duplicate #31636 report the same error on user machines (non-buildbot, as here). #25191proposes the following patch to skip this failure.

-        locale.setlocale(locale.LC_CTYPE, loc)
-        self.assertEqual(loc, locale.getlocale(locale.LC_CTYPE))
+        try:
+            locale.setlocale(locale.LC_CTYPE, loc)
+            self.assertEqual(loc, locale.getlocale(locale.LC_CTYPE))
+        except locale.Error:
+            # Unsupported locale setting
+            self.skipTest('unsupported locale setting')

I believe that this is effectively the same as deleting the test.  But if we believe it is being skipped on at least Windows buildbots, then we should do the same at least on user Windows machines.  Or, if we could detect user manchines, skip on them.
History
Date User Action Args
2020-12-08 14:06:02terry.reedysetrecipients: + terry.reedy, paul.moore, vstinner, tim.golden, guy.linton, zach.ware, serhiy.storchaka, eryksun, steve.dower, xtreak
2020-12-08 14:06:02terry.reedysetmessageid: <1607436362.71.0.827254772223.issue37945@roundup.psfhosted.org>
2020-12-08 14:06:02terry.reedylinkissue37945 messages
2020-12-08 14:06:02terry.reedycreate