Matthias Klose
> "The os-release file has been a well-defined standard for over 8 years."
> ... doesn't implicate that it's a good style to base your checks on that information.

IMO /etc/os-release is a reliable way to retrieve the Linux distribution name. What do you suggest to get the Linux distribution otherwise?


> the Chef repo seems to be a little bit out-of-date, but anyway. I don't see the relevance for this issue.

Someone can use it to test the implementation.

IMO it's interesting to see which Linux distributions provide os-release. The list of quite long!

* alpine_3_8
* amazon_2
* amazon_2018
* antergos
* arch
* archarm
* centos_7
* clearlinux_1
* clearos_7
* cumulus_3_7
* debian_7
* debian_8
* debian_9
* elementary_5
* fedora_28
* gentoo
* ios_xr_6
* kali_2018_4
* linuxmint_18_2
* linuxmint_19
* mangeia_6
* manjaro
* nexus_7
* nixos
* opensuseleap_15_0
* opensuseleap_15_1
* opensuseleap_42_3
* oracle_7
* rancheros_1_4
* raspbian_10
* raspbian_8
* redhat_7
* redhat_8
* scientific_7
* slackware_14_2
* sled_12_3
* sled_15
* sles_11_4
* sles_12_3
* sles_15_0
* sles_15_1
* sles_sap_12_0
* sles_sap_12_1
* sles_sap_12_2
* sles_sap_12_3
* ubuntu_1404
* ubuntu_1604
* ubuntu_1804
* xbian
* xcp_7_5_0
* xenserver_7_6

It's not like no Linux distribution provide the file. I don't know most of these Linux distributions :-D