Message381199
> I don't see how Py_NewRef() or Py_XNewRef() is less error prone. In my experience, any change is more likely to introduce new bugs than leaving the code unchanged.
Agree that inserting changes opens a door to introducing bugs.
However, the "end state" of having Py_NewRef() is desired, I think. It is more concise. It is less error prone because where you use it, you literally can't miss the "increment refcount" part when stealing a reference from another source. Py_INCREF has to come before/after stealing a ref, leaving room for error, IMHO.
> In general, we don't accept changes which are only coding style changes.
Didn't know that. Well if that's the case, then obviously there is no reason to work specifically on this conversion. |
|
Date |
User |
Action |
Args |
2020-11-17 01:04:11 | Yonatan Goldschmidt | set | recipients:
+ Yonatan Goldschmidt, vstinner |
2020-11-17 01:04:11 | Yonatan Goldschmidt | set | messageid: <1605575051.39.0.916351091388.issue42287@roundup.psfhosted.org> |
2020-11-17 01:04:11 | Yonatan Goldschmidt | link | issue42287 messages |
2020-11-17 01:04:10 | Yonatan Goldschmidt | create | |
|