➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients Yonatan Goldschmidt, vstinner
Date 2020-11-09.08:35:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1604910914.96.0.0298414657516.issue42287@roundup.psfhosted.org>
In-reply-to
Content 
> Following https://bugs.python.org/issue42262, I think it'd be nice to convert existing C code to use the more concise Py_NewRef() and Py_XNewRef() where possible. Increases readability and less bug prone. 

In general, we don't accept changes which are only coding style changes.

I don't see how Py_NewRef() or Py_XNewRef() is less error prone. In my experience, any change is more likely to introduce new bugs than leaving the code unchanged. See https://github.com/python/cpython/pull/23170 for a concrete case of a PR which converts code to Py_NewRef() / Py_XNewRef(): the PR introduced bugs (in early versions of the PR).
History
Date User Action Args
2020-11-09 08:35:14vstinnersetrecipients: + vstinner, Yonatan Goldschmidt
2020-11-09 08:35:14vstinnersetmessageid: <1604910914.96.0.0298414657516.issue42287@roundup.psfhosted.org>
2020-11-09 08:35:14vstinnerlinkissue42287 messages
2020-11-09 08:35:14vstinnercreate